This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
check if cacert string is path to a file #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=========================================
+ Coverage 83.74% 83.85% +0.1%
=========================================
Files 49 49
Lines 2559 2576 +17
=========================================
+ Hits 2143 2160 +17
Misses 287 287
Partials 129 129
Continue to review full report at Codecov.
|
the following change will first test if the provided string is a path to a file containing the certificate and if so, read the cert from the file, it os.Stat returns an error, it is assumed to be the raw cert string fixes #332
jipperinbham
force-pushed
the
332-cacert-fix
branch
from
2f560f4
to
133e262
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the following change will first test if the provided string is a path to a file containing the certificate and if so, read the cert from the file, it os.Stat returns an error, it is assumed to be the raw cert string
fixes #332