Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Capture flush errors #399

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Capture flush errors #399

merged 1 commit into from
Aug 16, 2017

Conversation

jipperinbham
Copy link
Contributor

@jipperinbham jipperinbham commented Aug 16, 2017

while completing the integration tests migration from travisci to semaphoreci, it was discovered that bulk flushes occurring in the go routine were erroring and not bubbling up. the following change attempts to both log and stop transporter when a bulk flush error occurs outside of the Write func.

  • CHANGELOG.md updated

@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #399 into master will decrease coverage by 0.61%.
The diff coverage is 18.51%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #399      +/-   ##
========================================
- Coverage   84.62%    84%   -0.62%     
========================================
  Files          59     59              
  Lines        4084   4102      +18     
========================================
- Hits         3456   3446      -10     
- Misses        467    486      +19     
- Partials      161    170       +9
Impacted Files Coverage Δ
adaptor/rethinkdb/writer.go 75.47% <10%> (-7.7%) ⬇️
adaptor/mongodb/bulk.go 74.22% <12.5%> (-6.21%) ⬇️
adaptor/elasticsearch/clients/v2/writer.go 80.72% <25%> (-2.83%) ⬇️
adaptor/elasticsearch/clients/v5/writer.go 80.72% <40%> (-2.83%) ⬇️
adaptor/postgres/tailer.go 78.21% <0%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2c6c4...63ed68c. Read the comment docs.

@jipperinbham jipperinbham deleted the capture-flush-errors branch August 16, 2017 18:30
@jipperinbham jipperinbham merged commit 6a9775e into master Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant