This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
postgres/tailer: data change row detection fixed #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression for detecting data change rows could not handle newlines in data fields correctly. The reason was, that the dot-directive in golang does not consume newlines by default. With the regexp option (?s) this is fixed now.
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 86.36% 86.14% -0.23%
==========================================
Files 61 61
Lines 3587 3587
==========================================
- Hits 3098 3090 -8
- Misses 320 327 +7
- Partials 169 170 +1
Continue to review full report at Codecov.
|
|
only lint failures for other adaptors, will clean those up soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have newlines in database fields, the postgres tailer will not work.
This is due to the regular expression that is used to detect change rows in the data from the used
replication slot .
The regular expression uses the dot-directive which does not consume newlines by default. This issues the newline problem. With this slightly modified regular expression, the problem can be solved.