This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Make list informative, stop arg panics #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For list command, precede the output with the name of the node. For run, eval, test commands, stop panic when no params and give informative error.
| for _, v := range config.Nodes { | ||
| fmt.Println(v) | ||
| for n, v := range config.Nodes { | ||
| fmt.Println(n, v) |
There was a problem hiding this comment.
This is ok, but I would prefer that we add a String() method to the Node struct. I'll show you what I mean after I merge this
There was a problem hiding this comment.
I was wrong about the string method, I forgot that we were defining that node within the config struct, so what i suggested wasn't workable.
as a work around, I just made the change here more readable
please see: https://github.com/compose/transporter/pull/10/files
nstott
added a commit
that referenced
this pull request
Dec 18, 2014
Make list informative, stop arg panics
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For list command, precede the output with the name of the node.
For run, eval, test commands, stop panic when no params and give
informative error.