Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

RethinkDB: Changes for v1 RethinkDB driver #83

Merged
merged 1 commit into from
Jul 3, 2015
Merged

RethinkDB: Changes for v1 RethinkDB driver #83

merged 1 commit into from
Jul 3, 2015

Conversation

codepope
Copy link
Contributor

@codepope codepope commented Jul 1, 2015

Updated for RethinkDB driver 1.0
Changed Db to DB mostly.

Updated for RethinkDB driver 1.0
Changed Db to DB mostly.
@nstott
Copy link
Contributor

nstott commented Jul 3, 2015

Thanks for this
Probably important to note that this version of the rethink driver only supports newer rethinkdb versions,
from the README:
Please note that this version of the driver only supports versions of RethinkDB using the v0.4 protocol (any versions of the driver older than RethinkDB 2.0 will not work).

nstott added a commit that referenced this pull request Jul 3, 2015
RethinkDB: Changes for v1 RethinkDB driver
@nstott nstott merged commit 08846f2 into compose:master Jul 3, 2015
@jipperinbham
Copy link
Contributor

@codepope
Copy link
Contributor Author

codepope commented Jul 3, 2015

But @jipperinbham doesn't that just ensure that the tail functionality needed is present (i.e. that the server is greater than 1.16 when all the change feed stuff landed officially)? If so, then just checking you have 1.16 should be correct, though, if a protocol check (for 0.4) is added earlier, never got to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants