New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer virtual packages are reported as ignored #93
Comments
related to: #217 |
I tested this bug and I get the following output:
My example project: https://github.com/markuspoerschke/composer-unused-test/tree/issue-93
Since the package is reported as ignored, I think this issue can be closed. |
No, they should not be reported at all. As they impose a requirement for the using application and do not add a "real" dependency |
Solved with #223 |
Describe the bug
Running
composer unused
in a library that requires a virtual package (e.g.psr/log-implementation
) composer unused is obviously not able to locate the package. Packages with the-implementation
suffix should not be reported at all.Additional information
https://devedge.wordpress.com/2014/09/27/composer-and-virtual-packages/
https://matthiasnoback.nl/2014/10/composer-provide-and-dependency-inversion/
As the
excludePackage
feature was added back again with #222.This issue can utilize this implementation to actually match packages ending with
-implementation
to be ignored as well.This could be done somewhere around here:
https://github.com/composer-unused/composer-unused/blob/main/src/Command/Handler/CollectFilteredDependenciesCommandHandler.php#L17
The text was updated successfully, but these errors were encountered: