Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 470 #522

Merged
merged 5 commits into from
May 23, 2023
Merged

Issue 470 #522

merged 5 commits into from
May 23, 2023

Conversation

MarcinGladkowski
Copy link
Contributor

@MarcinGladkowski MarcinGladkowski commented May 23, 2023

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Hi!
@icanhazstring

I based on specific TYPO3 packages. Example below:

vendor/composer/installed.php

        'typo3/cms-backend'' => array(
            // ...
            'type' => 'library',
            'install_path' => __DIR__ . '/../../public/typo3/sysext/backend',
           // ...
        ),

public/typo3/sysext/fluid/composer.json

{
	"name": "typo3/cms-backend",
	"type": "typo3-cms-framework",
        // ...
	"autoload": {
		"psr-4": {
			"TYPO3\\CMS\\Backend\\": "Classes/"
		}
	}
}

I decided to allow configure custom dependencies directory. I hope, I understand it correctly.
But there are other dependencies installed in vendor/ dir.

Ref: #470

@icanhazstring
Copy link
Member

Just a small question otherwise looks good 👍

@icanhazstring icanhazstring merged commit e3eaba8 into composer-unused:main May 23, 2023
11 checks passed
@icanhazstring
Copy link
Member

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants