Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 534 #539

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Issue 534 #539

merged 4 commits into from
Jun 18, 2023

Conversation

MarcinGladkowski
Copy link
Contributor

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@icanhazstring
Copy link
Member

icanhazstring commented Jun 18, 2023 •
edited

Pretty cool. Thanks 🙂
Give me a ping if you are finished 👍

@MarcinGladkowski
Copy link
Contributor Author

@icanhazstring I'm wondering about not passing two tests on actions. Both tests are using chdir() and failing.

It started failing from 2 weeks ago on MR branches.
https://github.com/composer-unused/composer-unused/actions/workflows/validate-code.yml

@icanhazstring
Copy link
Member

Hm ok. That seems weird. Also that it's only happening with 8.1 and 8.2 but not prior 🤔

Do they work locally?

@MarcinGladkowski
Copy link
Contributor Author

MarcinGladkowski commented Jun 18, 2023 •
edited

Screenshot from 2023-06-18 12-39-28
Yes. It's passing locally. That's why I'm debugging manually on Actions. :/

@icanhazstring
Copy link
Member

That is why I hate debugging actions 😅
Is there maybe some camel casing Problem?

@icanhazstring
Copy link
Member

icanhazstring commented Jun 18, 2023 •
edited

Seems that it works now 😅
Maybe squash the debugging commits then we could merge 🙂

@MarcinGladkowski
Issue_534: add assets for tests
caca1a5 
Issue_534: debug github actions

Issue_534: debug github actions - chdir

Issue_534: debug github actions - installed json file

Issue_534: debug github actions - downgrade phpdoc-parser

Issue_534: debug github actions - change setup chdir

Issue_534: debug github actions - remove Integrations

Issue_534: debug github actions - back with phpdoc parser

Issue_534: debug github actions - remove test directory

Issue_534: debug github actions - remove chdir() usage

Issue_534: debug github actions - remove duplicated execution in debugging tests

Issue_534: remove debug statement
@MarcinGladkowski
Copy link
Contributor Author

MarcinGladkowski commented Jun 18, 2023 •
edited

I edited tests which are using chdir(). That's why it's started working. Of course, I squashed commits.

@MarcinGladkowski
Copy link
Contributor Author

I want to mention besides this problem I checked carefully code generated by Composer and I don't see any other way to check which Composer Version was used to install packages.

@icanhazstring icanhazstring merged commit 4a27d9f into composer-unused:main Jun 18, 2023
11 checks passed
@icanhazstring
Copy link
Member

Thanks for the addition 💪

@MarcinGladkowski
Copy link
Contributor Author

It's pleasure for me. Have a nice day 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcinGladkowski @icanhazstring