Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience when adding additional files #552

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

icanhazstring
Copy link
Member

This will raise an exception when Configuration::setAdditionalFileFor is called multiple times. This should give the user a hint on how to add multiple files.

Resolve #513

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This will raise an exception when Configuration::setAdditionalFileFor is called multiple times. This should give the user a hint on how to add multiple files.
@icanhazstring icanhazstring force-pushed the feature/set-additional-files-ux branch from 3079cb5 to b42e44a Compare July 6, 2023 09:32
@icanhazstring icanhazstring merged commit 3129471 into main Jul 6, 2023
11 checks passed
@icanhazstring icanhazstring deleted the feature/set-additional-files-ux branch July 6, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase DX for setAdditionalFilesFor() method
1 participant