Skip to content
Permalink
Browse files
Disable GC when computing deps, refs #3482
  • Loading branch information
Seldaek committed Dec 2, 2014
1 parent 91dd999 commit ac676f47f7bbc619678a29deae097b6b0710b799
Showing 1 changed file with 2 additions and 0 deletions.
@@ -160,6 +160,8 @@ public function __construct(IOInterface $io, Config $config, RootPackageInterfac
*/

This comment has been minimized.

Copy link
@Seldaek

Seldaek Dec 4, 2014

Author Member

For anyone looking for an explanation, http://blog.ircmaxell.com/2014/12/what-about-garbage.html is a good write-up on GC in PHP, why it failed in this case, and why you probably should leave it enabled in your project!

https://news.ycombinator.com/item?id=8686934 also has some relevant comments.

This comment has been minimized.

Copy link
@wudi

wudi Dec 9, 2014

Cool! Awesome!

This comment has been minimized.

This comment has been minimized.

Copy link
@coral

coral Nov 20, 2015

wtf is going on here

This comment has been minimized.

Copy link
@hanmeimeia

hanmeimeia Mar 1, 2017

wtf

public function run()

This comment has been minimized.

Copy link
@IPRIT

IPRIT Jan 1, 2015

Здесь был Саша.

This comment has been minimized.

Copy link
@mikield

mikield Apr 14, 2015

@IPRIT Привет Саша :)

{
gc_disable();

This comment has been minimized.

Copy link
@homm

homm Dec 2, 2014

Surprised, no one had thought to add a comment here.

This comment has been minimized.

Copy link
@homm

homm Dec 2, 2014

This is bad smelling code, by the way.

This comment has been minimized.

Copy link
@emiralp

emiralp Dec 2, 2014

yay

This comment has been minimized.

Copy link
@ncovercash

ncovercash Dec 2, 2014

mmm. no comments. Lets disable core php functions without explaining why we do so.

This comment has been minimized.

Copy link
@fprochazka

fprochazka Dec 2, 2014

Contributor

@smileytechguy it's explained in #3482

This comment has been minimized.

Copy link
@vibbow

vibbow Dec 2, 2014

火钳刘明

This comment has been minimized.

Copy link
@tooooolong

This comment has been minimized.

Copy link
@whyliam

whyliam Dec 3, 2014

This comment has been minimized.

Copy link
@leozvc

leozvc Dec 3, 2014

w wsoly e744y_3 o_ r
萌哭!

This comment has been minimized.

Copy link
@codexss

codexss Dec 3, 2014

CO0O0O0O0OO0O0OL

This comment has been minimized.

Copy link
@bakso

bakso Dec 3, 2014

You Ge Diao Mao, silly B

This comment has been minimized.

Copy link
@chareice

chareice Dec 3, 2014

Shen me gui!

This comment has been minimized.

Copy link
@coolicer

coolicer Dec 3, 2014

why a u so diao

This comment has been minimized.

Copy link
@wenerme

wenerme via email Dec 3, 2014

This comment has been minimized.

Copy link
@lzswangjian

lzswangjian Dec 3, 2014

f**k

This comment has been minimized.

Copy link
@sheershoff

This comment has been minimized.

Copy link
@fprochazka

fprochazka Dec 4, 2014

Contributor

@sheershoff nice one!

This comment has been minimized.

Copy link
@hasantayyar

if ($this->dryRun) {
$this->verbose = true;
$this->runScripts = false;

520 comments on commit ac676f4

@bacher
Copy link

@bacher bacher commented on ac676f4 Dec 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirugan
Copy link

@kirugan kirugan commented on ac676f4 Dec 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@terry-fei
Copy link

@terry-fei terry-fei commented on ac676f4 Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js发来贺电

@wentingwei
Copy link

@wentingwei wentingwei commented on ac676f4 Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pp

@lebronfaling
Copy link

@lebronfaling lebronfaling commented on ac676f4 Dec 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the most brilliant move on programming I have seen myself. I tested it on my Android site which was hosted on a LAMP stack. The performance is 5X after this commit.

@cnryb
Copy link

@cnryb cnryb commented on ac676f4 Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

到此一游~~~~~~~~~~~~~~~~

@hiram3512
Copy link

@hiram3512 hiram3512 commented on ac676f4 Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我跟你什么仇什么怨..............打开页面直接卡死,对php只想说不觉明历,C#发来贺电

@neruthes
Copy link

@neruthes neruthes commented on ac676f4 Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ever since bumblebee.

@iMactool
Copy link

@iMactool iMactool commented on ac676f4 Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【我是李彦宏】
在此 image

@vitalif
Copy link

@vitalif vitalif commented on ac676f4 Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy I'm almost not using PHP frameworks and libraries and therefore I don't need composer.
What the hell is it doing that it consumes so much memory and so much time? O_o

@AntiMoron
Copy link

@AntiMoron AntiMoron commented on ac676f4 Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈哈哈哈哈哈哈哈哈。妈个J不明觉厉。

hahhahahahahahah.WTF although I don't know what are you guys talking about but feeling it's really awesome.

@zikezhang
Copy link

@zikezhang zikezhang commented on ac676f4 Dec 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP you so crazy.

@Jackie-Innover
Copy link

@Jackie-Innover Jackie-Innover commented on ac676f4 Dec 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to say, my chrome is OK.

@nauxliu
Copy link

@nauxliu nauxliu commented on ac676f4 Dec 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

围观~

@caoglish
Copy link

@caoglish caoglish commented on ac676f4 Dec 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great post. awesome

@simapple
Copy link

@simapple simapple commented on ac676f4 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e

@taiwen
Copy link

@taiwen taiwen commented on ac676f4 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome!

@Rivsen
Copy link

@Rivsen Rivsen commented on ac676f4 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops...

@zhanghanyun
Copy link

@zhanghanyun zhanghanyun commented on ac676f4 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP is the best programing language in the world!!!

@gpilla
Copy link

@gpilla gpilla commented on ac676f4 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great news!

After: Memory usage: 157.47MB (peak: 459.95MB), time: 198.09s
Before: Memory usage: 157.05MB (peak: 457.34MB), time: 34.26s

@vucalur
Copy link

@vucalur vucalur commented on ac676f4 Dec 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanovsaleksejs Please insert your link as inline graphics

@zhukejin
Copy link

@zhukejin zhukejin commented on ac676f4 Dec 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

观光..顺便关注下PHP的GC

@vforge
Copy link

@vforge vforge commented on ac676f4 Dec 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging in legendary thread. OP delivered.

@sstrato
Copy link

@sstrato sstrato commented on ac676f4 Dec 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

성지 순례왔어요. 내년엔 반드시 이루어주시길 부탁드려요.
That's awesome patch. now i can make my DC working!

@IPRIT
Copy link

@IPRIT IPRIT commented on ac676f4 Dec 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@dolonfly
Copy link

@dolonfly dolonfly commented on ac676f4 Jan 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memory usage: 140.9MB ,50.01s

@dolonfly
Copy link

@dolonfly dolonfly commented on ac676f4 Jan 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e7cd7b899e510fb39f4911fcda33c895d1430c0c

@Capster
Copy link

@Capster Capster commented on ac676f4 Jan 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toxmc
Copy link

@toxmc toxmc commented on ac676f4 Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq 20150105174412

hello world...

@krgn
Copy link

@krgn krgn commented on ac676f4 Jan 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f*ckyeah

@saadel
Copy link

@saadel saadel commented on ac676f4 Jan 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zianwar
Copy link

@zianwar zianwar commented on ac676f4 Jan 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saadel hhhh

@chapai
Copy link

@chapai chapai commented on ac676f4 Jan 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!

@cisiqo
Copy link

@cisiqo cisiqo commented on ac676f4 Jan 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB

@caryxiao
Copy link

@caryxiao caryxiao commented on ac676f4 Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 n_2 0hsojj 3aa 0nn0so

@sheak
Copy link

@sheak sheak commented on ac676f4 Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你们介四个嘛

@TaXueWWL
Copy link

@TaXueWWL TaXueWWL commented on ac676f4 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I'am late

@PandaTwo
Copy link

@PandaTwo PandaTwo commented on ac676f4 Mar 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要被玩坏了!

@wilon
Copy link

@wilon wilon commented on ac676f4 Mar 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62037b5ajw1eniif298krg209q09qkjl

@nick4fake
Copy link

@nick4fake nick4fake commented on ac676f4 Apr 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I really like PHP.

@denniskupec
Copy link

@denniskupec denniskupec commented on ac676f4 Oct 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working

@sheak
Copy link

@sheak sheak commented on ac676f4 Oct 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiroming
Copy link

@shiroming shiroming commented on ac676f4 Oct 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我就看看。不说话。

@ethe
Copy link

@ethe ethe commented on ac676f4 Oct 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

来晚了。。我就凑个热闹

@yw79641760
Copy link

@yw79641760 yw79641760 commented on ac676f4 Oct 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php_disable() +1

@kn007
Copy link

@kn007 kn007 commented on ac676f4 Oct 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@stevenlordiam
Copy link

@stevenlordiam stevenlordiam commented on ac676f4 Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO AWESOME, you guys rock!

@sximaget
Copy link

@sximaget sximaget commented on ac676f4 Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha exactly that makes up for the "wtf how did I miss this for so long I am such an idiot" ;) When I disable the function as described above, my Recovery &Transfer site's performance doubles in just a few second.
Really wish profilers would show GC info in the output.

@jiaqizho
Copy link

@jiaqizho jiaqizho commented on ac676f4 Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diss my big dick !!!!!!!!!
顺带�摸摸楼上韩国人狗头

@maguowei
Copy link

@maguowei maguowei commented on ac676f4 Oct 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

@progsmile
Copy link

@progsmile progsmile commented on ac676f4 Feb 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!!!)))

@benbieler
Copy link

@benbieler benbieler commented on ac676f4 Mar 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warnerarchive-classic-film-hammer-films-taste-the-blood-of-dracula-3oEdv4dMyB0CC0Vck0

@PurlingNayuki
Copy link

@PurlingNayuki PurlingNayuki commented on ac676f4 Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark here for finish this page without get killed (but yes, lag)
Firefox Beta 51b7 64-bit / Windows 10 1607 Update with around 2112MB memory usage.

@ncovercash
Copy link

@ncovercash ncovercash commented on ac676f4 Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PurlingNayuki Yes, loading this page was worse than most news sites

@wenma
Copy link

@wenma wenma commented on ac676f4 Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

火前留名

@rquadling
Copy link

@rquadling rquadling commented on ac676f4 Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

约瑟夫
Chinese: Joseph
Japanese: .... !!!!!

Something to remember to NOT get tattooed or on a t-shirt!!!!

@wilon
Copy link

@wilon wilon commented on ac676f4 Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@fanfanlei
Copy link

@fanfanlei fanfanlei commented on ac676f4 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23333

@charleslxh
Copy link

@charleslxh charleslxh commented on ac676f4 Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the reason why it often has "memory leak error" when installing libs?

@andriuspetrauskis
Copy link

@andriuspetrauskis andriuspetrauskis commented on ac676f4 Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kazoo

Please sign in to comment.