Enable new phpstan option

composer · May 27, 2024 · f83b6b1 · f83b6b1
1 parent 09e616f
commit f83b6b1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/phpstan/config.neon b/phpstan/config.neon
@@ -21,6 +21,7 @@ parameters:
 
     reportUnmatchedIgnoredErrors: false
     treatPhpDocTypesAsCertain: false
+    reportPossiblyNonexistentConstantArrayOffset: true
 
     ignoreErrors:
         # unused parameters

diff --git a/src/Composer/Command/RequireCommand.php b/src/Composer/Command/RequireCommand.php
@@ -402,6 +402,8 @@ private function getPackagesByRequireKey(): array
 
     /**
      * @param array<string, string> $requirements
+     * @param 'require'|'require-dev' $requireKey
+     * @param 'require'|'require-dev' $removeKey
      * @throws \Exception
      */
     private function doUpdate(InputInterface $input, OutputInterface $output, IOInterface $io, array $requirements, string $requireKey, string $removeKey): int

diff --git a/tests/Composer/Test/Command/LicensesCommandTest.php b/tests/Composer/Test/Command/LicensesCommandTest.php
@@ -78,6 +78,9 @@ public function testBasicRun(): void
                 continue;
             }
 
+            if (!isset($expected[$i])) {
+                $this->fail('Got more output lines than expected');
+            }
             $this->assertMatchesRegularExpression("/" . implode("\s+", $expected[$i]) . "/", $line);
         }
     }
@@ -108,6 +111,9 @@ public function testNoDev(): void
                 continue;
             }
 
+            if (!isset($expected[$i])) {
+                $this->fail('Got more output lines than expected');
+            }
             $this->assertMatchesRegularExpression("/" . implode("\s+", $expected[$i]) . "/", $line);
         }
     }