Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom binaries directory, composer-php includes and PEAR #1001

Closed
alurin opened this issue Aug 14, 2012 · 5 comments
Closed

Custom binaries directory, composer-php includes and PEAR #1001

alurin opened this issue Aug 14, 2012 · 5 comments
Labels
Milestone

Comments

@alurin
Copy link

alurin commented Aug 14, 2012

With this part of composer.json :

...
"config": {
    "bin-dir":          "bin/",
    ...
}
...

composer-php and composer-php.bat not corrected collected include paths from vendor directory for php executable, because it's considers location of binary directory is child of vendor dir

Line with error from composer-php:

3: BIN_DIR=`dirname $(readlink -f $0)`
4: VENDOR_DIR=`dirname $BIN_DIR`
@Seldaek
Copy link
Member

Seldaek commented Aug 14, 2012

Do you know which package I can use to try and reproduce this? I think I figured out how to fix the issue but it'd be great to have a repro case just to confirm it.

@alurin
Copy link
Author

alurin commented Aug 15, 2012

PHP static checks tool: PHPUnit, PHP_CodeSniffer

{
    "require": {
        "pear-phpunit/phpunit":                 "3.6.11",
        "pear/php_codesniffer":                 "1.3.6",
        "pear-pear.php.net/pear":               "*",
        "phpqatools/php_codebrowser":           "1.0.3"
    },
    "repositories": [
        {
            "type": "pear",
            "url":  "pear.phpunit.de"
        },
        {
            "type": "pear",
            "url":  "pear.symfony-project.com"
        },
        {
            "type":         "pear",
            "url":          "pear.php.net",
            "vendor-alias": "pear"
        },
        {
            "type":         "pear",
            "url":          "pear.phpqatools.org",
            "vendor-alias": "phpqatools"
        }
    ],
    "config": {
        "bin-dir":          "bin/",
        "process-timeout":  700
    }
}

@Seldaek
Copy link
Member

Seldaek commented Aug 15, 2012

Alright this should now be fixed. Worked for me on windows, if you get a chance to also try it on OSX or Linux it'd be cool, but either way confirming it works would be nice too.

@alurin
Copy link
Author

alurin commented Aug 15, 2012

Ok. I'll check after work

@alurin
Copy link
Author

alurin commented Aug 15, 2012

On Ubuntu and Debian all fine. PHPUnit and PHP_CodeSniffer run and worked.

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants