Pass CommandEvent instead of Event

[trivago-makbarof]

Hi
We want to define a script in our composer.json called "prepare-deploy"

We wanted to call buildBootstrap inside of the script but as this script is not in set of Composer\Command\RunScriptCommand::$commandEvents you're passing Event class to that command

I propose to add a new option called as-command in RunScriptCommand so the user can force composer to pass CommandEvent to the command

https://gist.github.com/trivago-makbarof/4cc2229ef9384c33ce8b

Currently we have fixed the problem with calling our own script handler which converts Event to CommandEvent the calls the sensio script handler

Thanks

[galphanet]

I support this issue. I don't understand why it was designed this way though.

[Seldaek]

Why is probably historical reasons, but indeed it's kinda broken the way it is, and as CommandEvent extends from the base Event without adding anything they are fully compatible.

The best fix to avoid breaking BC issues with existing packages is to detect what the callback expects with reflection and if it's a CommandEvent we copy the event info to a new CommandEvent in case we don't have one yet.

[galphanet]

While waiting for the fix, here is the code we use to convert the object, if this can be useful for someone :

use Composer\Script\CommandEvent;
use Composer\Script\Event;



    /**
     * Convert Event in EventCommand.
     * @param $event Event A instance
     * @return EventCommand
     */
public static function convertEventToCommandEvent(Event $event) {
        return new CommandEvent($event->getName(), $event->getComposer(), $event->getIO(), $event->isDevMode(), $event->getArguments());
    }

[alcohol]

# ./composer.json
{
  "require": {
    "sensio/distribution-bundle": "@stable"
  },
  "scripts": {
    "prepare-deploy": [
      "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap"
    ]
  }
}

$ composer prepare-deploy

This is what you're trying to run, if I understand correctly?

[galphanet]

Exact, but I don't call Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap but a custom PHP class.