Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter answer checking for init #5989

Closed
kelunik opened this issue Dec 22, 2016 · 2 comments
Closed

Stricter answer checking for init #5989

kelunik opened this issue Dec 22, 2016 · 2 comments
Labels
Bug
Milestone
Bugs

Comments

@kelunik
Copy link

kelunik commented Dec 22, 2016

composer init currently doesn't enforce yes|y|no|n as an answer to bool questions like the one below. Somehow I wanted to directly search now multiple times, but that results in a no instead of asking again with a hint of valid answers.

Current

Would you like to define your dependencies (require) interactively [yes]? async-interop
Would you like to define your dev dependencies (require-dev) interactively [yes]? ^C

Expected

Would you like to define your dependencies (require) interactively [yes]? async-interop
Please answer yes, y, no, or n.
Would you like to define your dependencies (require) interactively [yes]?
@Seldaek Seldaek added the Bug label Dec 23, 2016
@Seldaek Seldaek added this to the Bugs milestone Dec 23, 2016
theotonge added a commit to theotonge/composer that referenced this issue Apr 3, 2017
@theotonge
WIP Fix for composer#5989
329d329 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 3, 2017
@theotonge
WIP Fix for composer#5989
a07a352 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 7, 2017
@theotonge
WIP Fix for composer#5989
3533d13 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 7, 2017
@theotonge
Fix for composer#5989
57e7607 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 7, 2017
@theotonge
Fix for composer#5989
549fde3 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 7, 2017
@theotonge
Fix for composer#5989
bbe8905 
Enforce yes/no answers for boolean questions during init command
@theotonge theotonge mentioned this issue Apr 7, 2017
Merged
theotonge added a commit to theotonge/composer that referenced this issue Apr 9, 2017
@theotonge
Fix for composer#5989
d83844a 
Enforce yes/no answers for boolean questions during init command
theotonge added a commit to theotonge/composer that referenced this issue Apr 10, 2017
@theotonge
Fix for composer#5989
ebf5712 
Enforce yes/no answers for Confirmation Questions
theotonge added a commit to theotonge/composer that referenced this issue Apr 10, 2017
@theotonge
Fix for composer#5989
14206d2 
Enforce yes/no answers for Confirmation Questions
theotonge added a commit to theotonge/composer that referenced this issue Apr 10, 2017
@theotonge
Fix for composer#5989
c077df0 
Enforce yes/no answers for Confirmation Questions
Seldaek added a commit that referenced this issue Apr 19, 2017
@Seldaek
Merge pull request #6337 from theotonge/bugfix-5989
123e895 
Fix for #5989
@tomzx
Copy link
Contributor

tomzx commented Dec 14, 2017

This appears to be fixed @ v1.5.5.

@Seldaek Can you please close this?

@Seldaek
Copy link
Member

Seldaek commented Dec 15, 2017

True that, thanks :)

@Seldaek Seldaek closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Bugs
Development

No branches or pull requests
3 participants
@Seldaek @tomzx @kelunik