Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root package marked as installed means it's dependencies are read always #669

Closed
Seldaek opened this issue May 9, 2012 · 1 comment
Closed

Root package marked as installed means it's dependencies are read always #669

Seldaek opened this issue May 9, 2012 · 1 comment
Assignees
@Seldaek
Labels
Bug Solver
Milestone
Alpha4

Comments

@Seldaek
Copy link
Member

Seldaek commented May 9, 2012

Even if you install from lock, since we now mark the root package for installation (to make sure it's not removed and not installed to another version in the vendors if a dependency relies on the root package), the solver will also try to require the dependencies of the root package, which if they're different than the lock file, can create issues/unsolvable stuff.
@Seldaek
Copy link
Member Author

Seldaek commented May 11, 2012

TODO: clone root package in installer and remove it's requirements before adding it to the installed repo

@ghost ghost assigned Seldaek May 12, 2012
romainneutron pushed a commit to romainneutron/composer that referenced this issue May 29, 2012
@naderman
Merge pull request composer#743 from Seldaek/rootfix
f418a63 
Root requires are not taken into account in locked installs, fixes composer#669
digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013
@Seldaek
Root requires are not taken into account in locked installs, fixes co…
d882725 
…mposer#669
digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013
@naderman
Merge pull request composer#743 from Seldaek/rootfix
6a4827d 
Root requires are not taken into account in locked installs, fixes composer#669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Seldaek Seldaek

Labels
Bug Solver
Projects
None yet
Milestone
Alpha4
Development

No branches or pull requests
1 participant
@Seldaek