New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with PHP 8.0-dev and Composer 2.0.0 #9331
Comments
Came here to say the same :-) https://github.com/doctrine/annotations/pull/372/checks?check_run_id=1301958168 |
.php8 😱 I thought we stopped doing this since php4 or something. I also see that this is only a problem in symfony/polyfill-mbstring 1.19.0 to which I upgraded just before the release... Obviously this "inconsequential" update had to mess things up. @nicolas-grekas any clue when the next release is planned? Or should I rather switch to dev-main? |
To make a release, we'd need to do a change before :) |
The file is not in the phar because we only include .php files, because the rest is supposedly useless. And symfony/polyfill-mbstring@39d483b already got rid of that file, that's why I ask :) |
I learned a similar lesson not too long ago ;) Since then, we do not only run the regular tests for PHPUnit but also build the PHAR and run additional tests to ensure that it works. |
But that commit also bumped the minimum version of PHP to 7.1, and I suppose you want your phar to run on php 5.3? |
@nicolas-grekas Right, ok yeah will fix this on our end then.. Thanks. @sebastianbergmann we actually do build a phar and run an install from it as part of CI AFAIK, but I guess we do have mbstring enabled and you don't or some such bad luck event.. |
Composer snapshot should now be fixed.. I gotta go for a while, can do a release later today. |
I have patched phars |
Thanks to everyone involved, you're awesome 👍 :) |
@shivammathur that's awesome, then I don't have to do a release so soon, I doubt anyone uses php8 much outside CI.. |
People using other CI systems like travis will still be affected. Travis runs |
2.0.1 is out now, with proper future proof fix so such accidents should hopefully not happen anymore. |
Just upgraded PHP with Homebrew, I have the same error with the latest Composer version. |
@LeRoyJulian please report a new issue with details as to what you see. |
Done #9522 |
Running Composer 2.0.0 with PHP 8.0-dev results in:
The text was updated successfully, but these errors were encountered: