Feature proposal: sorting keys by logical blocks #10089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the order is agreed on, the dumper should probably be updated to use the same order |
|
Dumper ok, i can. |
|
Just attaching the #10073 discussion so as not to search :) PS: I will make changes in the coming days. |
|
@stof, now I look at the If you configure the dumper so that it stores the keys in the order we need, then it will have to be completely rewritten. On the one hand, this can be done, and on the other, you can use the |
|
OK, seems fine to me, thanks. I agree shifting the whole dumper code isn't really worth it. |
|
Thank you |
|
Thank you, @andrey-helldar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of the discussion, this PR was created.
Only the order of the elements has been changed. Codestyle has remained the same.