Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scalar parameter type declaration #10186

Merged
merged 1 commit into from Oct 19, 2021
Merged

Remove scalar parameter type declaration #10186

merged 1 commit into from Oct 19, 2021

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Oct 19, 2021

string can only be used in parameters starting from PHP 7.0.

Was added in #10115

@herndlm
Remove scalar parameter type declaration
9b6cfbe 
`string` can only be used in parameters starting from PHP 7.0.
@herndlm herndlm mentioned this pull request Oct 19, 2021
Merged
@stof
Copy link
Contributor

stof commented Oct 19, 2021

This tells me that this code is untested, otherwise the CI would have failed on PHP 5

@Seldaek
Copy link
Member

Seldaek commented Oct 19, 2021

@stof Yeah that's not a surprise, we have tons of untested code..

What's nasty with these scalar hints is that older PHP versions see them as class hints so it doesn't fail our PHP Lint CI.

Well spotted and thanks for the fix @herndlm :)

@Seldaek Seldaek merged commit f0cc9ae into composer:main Oct 19, 2021
@herndlm herndlm deleted the bugfix/remove-scalar-parameter-type-declaration branch October 19, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@herndlm @stof @Seldaek