New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation on platform dependencies #10313
Conversation
4915416
to
fb6fd44
Compare
Updated version of #9965 |
1afadf7
to
092b2c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs, I know I edited a lot, but really wouldn't have been this easy if you hadn't already provided all the content ;-)
Eh I see Jordi didn't wait for me to actually review as he asked, so my changes conflict with some of his. So ideally revert whatever @Seldaek tweaked in the docs and then just apply my suggestions? |
Thanks for the doc updates. I can now take care integrating them cleanly, resolving the conflicts. What I wasn't able to figure out is what PHPStan's complaint is about. So that will be something you'll need to fix in the end. |
a033046
to
725be42
Compare
@helhum great thanks! |
Co-authored-by: Nils Adermann <naderman@naderman.de>
Thanks everyone! |
No description provided.