Allow xdebug-handler 3.x, update deps #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
|
Okay, this is a bug because calling
Yes, I think it should do this.
Indeed. It just evolved this way, as things often do. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
@johnstevenson thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @johnstevenson see the hack I had to do in bootstrap.php - I am not sure why this is required with v3, or rather I am not sure why it worked before :)
But it would be nice if isXdebugActive would be working standalone as it is static.
I guess all of the following could be moved into it really, I don't know why this stuff is stored on instance props and not static ones:
https://github.com/composer/xdebug-handler/blob/ec6aa897c8b6cab05ebaeddade62bb6e4a69ef38/src/XdebugHandler.php#L94-L100
Keeping this PR open as reminder, if it gets fixed in xdebug-handler I will drop the hack on this end.