Clean up properly if self-update fails #10475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If self-update fails because the downloaded file cannot be renamed or copied, it is left wherever it was downloaded to. Because it was always given the same name (
composer-temp.phar
), this didn't seem much of a problem - and could allow the user to manually move it if things got hairy.However, it is now given a randomized name (3bb78fd) which produces multiple files, so this fix deletes the downloaded file on self-update failure.