added phpstan ConfigReturnTypeExtension

[staabm]

as discussed in ca3b874#commitcomment-68913659

[staabm]

at this early stage, this extension already provides enough type-inference to detect type of ca3b874

 ------ ------------------------------------------------------------------------------------------------
  Line   RemoveCommand.php
 ------ ------------------------------------------------------------------------------------------------
  238    Parameter #1 $array of function array_keys expects array, array<string, bool>|null given.
  240    Parameter #1 $value of function count expects array|Countable, array<string, bool>|null given.
 ------ ------------------------------------------------------------------------------------------------

[staabm]

@Seldaek you are more familiar with the composer schema... are you ok with finishing the PR from this point?

feel free to ping me regarding phpstan/phpstan-extension related questions.

[Seldaek]

Ok sure, thanks!

[staabm]

Looks promising already. I think it could make sense to ship a phpstan config with composer, meant for include in e.g. plugin projects which also use phpstan, so they also benefit from the static analysis enhancements.

if you have questions left, feel free to ask

[Seldaek]

Yeah good point, did that now, ready to merge IMO, this works great for Config! Thanks for the help getting started.

[staabm]

@Seldaek not sure we missed something, but it seems atm the phpstan folder is missing from vendor/composer/composer in my plugin project, which I just updated to 2.3.6

do we need to whitelist the phpstan folder somewhere, so it is part of the composer package?

[stof]

for non-required properties, the keys should be marked as optional keys (through the 4th argument)

[herndlm]

I can gladly open a PR adapting that. I didn't use JSON schema often yet, but I don't see many required fields there which would make almost all keys optional. I guess this is not the expected outcome, is it?
Ah and I just saw that apparently non-required props are already unioned with a NullType (still non-optional in the ConstantArray though). I'll wait before I adapt anything here.

[herndlm]

This had less impact than I thought: #10815

[stof]

Btw, I'm not sure an optional key actually allows null in json schemas.

[Seldaek]

I think my point was more that if it's optional and you call get() on it it may return null.

[stof]

But this is about a subkey of an array shape. You cannot call get on them

[Seldaek]

Yes I can see that, for that case I don't know.. maybe I was lost in recursion and this doesn't make sense here. I don't recall tbh.