Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json format of audit command missing affectedVersions, fix reportedAt format (BC BREAK!) #11120

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 13, 2022

Fixes #11104

This fixes the affectedVersions missing from the output, but also changes the reportedAt output from

                "reportedAt": {
                    "date": "2022-02-04 06:52:21.000000",
                    "timezone_type": 3,
                    "timezone": "UTC"
                },

to "reportedAt": "2022-02-04T06:52:21+00:00"

This is strictly speaking a BC break but the old format was kinda garbage so I think we rather fix this now while it's still early. It's an easy fix anyway and should trigger hard failures for anyone accessing the reportedAt>date field so it shouldn't get missed.

@Seldaek Seldaek merged commit f6e67e5 into composer:2.4 Oct 13, 2022
@Seldaek Seldaek deleted the fix_json_audit branch October 13, 2022 14:56
emahorvat52 pushed a commit to emahorvat52/composer that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants