-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[changelog] Add 2.2.18 #11163
[changelog] Add 2.2.18 #11163
Conversation
https://getcomposer.org/changelog/2.2.18 was returning a 404
@Seldaek ping ? |
Could this be merged? |
Is it really so urgent? I am not super happy with the solution as it'd mean having to backport every changelog change from 2.2 branch into main.. I haven't yet had time to figure out a better solution tho, so it's in limbo. |
@Seldaek the issue is that the download page of the website has a changelog link for each version. But the website uses the file from the main branch to read the changelog, so the link fails for 2.2.18 as the changelog only exists in the 2.2 branch. |
Yes I understand the issue.. I'd still like to find a better solution than having to merge changelogs. |
The solution might be to merge 2.2 up into newer branches after releasing new 2.2 versions. |
Not really urgent, just wanted to follow up. |
An option might be to make the changelog URL redirect to the GitHub release to see the changelog instead of parsing the changelog file of a given release. |
Yup, that's a good idea @stof - tho I fetched it from API instead of redirecting, but maybe it should redirect if the API call failed due to rate limit just for safety ;) |
https://getcomposer.org/changelog/2.2.18 was returning a 404, this should fix it.