Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog] Add 2.2.18 #11163

Closed
wants to merge 1 commit into from
Closed

[changelog] Add 2.2.18 #11163

wants to merge 1 commit into from

Conversation

captn3m0
Copy link

https://getcomposer.org/changelog/2.2.18 was returning a 404, this should fix it.

@usta
Copy link

usta commented Nov 9, 2022

@Seldaek ping ?

@captn3m0
Copy link
Author

Could this be merged?

@Seldaek
Copy link
Member

Seldaek commented Nov 15, 2022

Is it really so urgent?

I am not super happy with the solution as it'd mean having to backport every changelog change from 2.2 branch into main.. I haven't yet had time to figure out a better solution tho, so it's in limbo.

@stof
Copy link
Contributor

stof commented Nov 15, 2022

@Seldaek the issue is that the download page of the website has a changelog link for each version. But the website uses the file from the main branch to read the changelog, so the link fails for 2.2.18 as the changelog only exists in the 2.2 branch.

@Seldaek
Copy link
Member

Seldaek commented Nov 15, 2022

Yes I understand the issue.. I'd still like to find a better solution than having to merge changelogs.

@stof
Copy link
Contributor

stof commented Nov 15, 2022

The solution might be to merge 2.2 up into newer branches after releasing new 2.2 versions.

@captn3m0
Copy link
Author

Not really urgent, just wanted to follow up.

@stof
Copy link
Contributor

stof commented Nov 15, 2022

An option might be to make the changelog URL redirect to the GitHub release to see the changelog instead of parsing the changelog file of a given release.

@Seldaek
Copy link
Member

Seldaek commented Nov 17, 2022

Yup, that's a good idea @stof - tho I fetched it from API instead of redirecting, but maybe it should redirect if the API call failed due to rate limit just for safety ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants