Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add prettier checks #11506

Closed
wants to merge 3 commits into from
Closed

CI: add prettier checks #11506

wants to merge 3 commits into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jun 12, 2023

Hello,

In this PR, I am proposing the integration of Prettier in this project, aimed at enhancing the consistency of our .md and .json files across the entire codebase. Prettier, being an opinionated code formatter, will help us maintain a uniform code style and improve code readability.

One of the significant advantages of Prettier is its ability to read the existing .editorconfig and format files accordingly, ensuring that we adhere to established coding guidelines while also automating the formatting process.

Let me know what you think on this!

@drupol drupol marked this pull request as draft June 12, 2023 20:10
@drupol drupol marked this pull request as ready for review June 12, 2023 20:16
UPGRADE-2.0.md Outdated Show resolved Hide resolved
UPGRADE-2.0.md Outdated Show resolved Hide resolved
@Seldaek
Copy link
Member

Seldaek commented Jun 21, 2023

Thanks but no thanks.. I don't see the value add here, it's mostly "fixing" a few quotes and then reindenting all bullet lists with 3 spaces instead of one, which I don't see as an improvement, as I always write them with one it'll just nag me forever.

@Seldaek Seldaek closed this Jun 21, 2023
@drupol
Copy link
Contributor Author

drupol commented Jun 21, 2023

Fair enough, no problem I understand.

@drupol drupol deleted the ci/add-prettier-checks branch June 21, 2023 16:15
@Seldaek
Copy link
Member

Seldaek commented Jun 21, 2023

Sorry i have an allergy to most linting tools, it's so rigid and tends to just get in the way when working with open source IMO. It probably makes more sense in larger teams where many people work for longer periods on the same stuff. Anyway..

@drupol
Copy link
Contributor Author

drupol commented Jun 21, 2023

I totally understand regarding linting tools. They can indeed feel a bit too restrictive sometimes, especially when working in open source projects where there is often a wide range of coding styles and philosophies. It's an absolutely normal perspective and I'm not offended at all.

To me, PRs are by their very nature, a proposal, if you will. They provide an opportunity to suggest changes, but they're by no means a mandate. As such, I fully respect and appreciate your ability to say yes or no as a maintainer. That's part of what makes the open source community so dynamic and effective.

Rest assured, this won't prevent me from contributing in the future. Quite the opposite, in fact – I look forward to continuing to engage with and contribute to this project in whatever ways I can.

Cheers ! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants