Add support for phpunit 10 #11532
Merged
Add support for phpunit 10 #11532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using non-static methods as a data providers was deprecated in phpunit 10.
Abstract test case classes with Test suffix are deprecated in PHPUnit 10. We also change the ArchiverTest file name to match the new class name (ArchiverTestCase). * sebastianbergmann/phpunit#5132
localheinz
reviewed
Jul 16, 2023
| @@ -57,7 +57,7 @@ public function testHomeCommandWithShowFlag( | |||
| $this->assertSame(trim($expected), trim($appTester->getDisplay(true))); | |||
| } | |||
|
|
|||
| public function useCaseProvider(): Generator | |||
| public static function useCaseProvider(): Generator | |||
There was a problem hiding this comment.
You could use the php_unit_data_provider_static fixer of friendsofphp/php-cs-fixer here.
Perhaps extract into a separate pull request?
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.