Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bumping for patch level version constraints (fixes #11579) #11590

Conversation

verfriemelt-dot-org
Copy link
Contributor

hi,

i think this is quite a straight forward thing and i think its very benefical to support bumping patch level constraints.
this will enable the mentioned constraint from #11579 to be updated

{
  "require-dev": {
    "phpstan/phpstan": "~1.10.0"
  }
}

what do you think?

@verfriemelt-dot-org verfriemelt-dot-org changed the title allow bumping for patch level version constraints fixes #11579 allow bumping for patch level version constraints (fixes #11579) Aug 20, 2023
@verfriemelt-dot-org
Copy link
Contributor Author

btw, the PHPStan / PHPStan (8.1, true) pipeline should not be related to my changes at all 🤔

@MirakuSan
Copy link
Contributor

I had the same problem on my PR #11551 with PHP 8.1 actions, seems that rebasing with master fix the issue, did you try it ?

@verfriemelt-dot-org
Copy link
Contributor Author

this should go into 2.5, not into master. thats why i created #11594

@Seldaek
Copy link
Member

Seldaek commented Aug 30, 2023

Please rebase on main, but otherwise looks good to me I think.

@Seldaek Seldaek requested a review from naderman August 30, 2023 15:41
@verfriemelt-dot-org verfriemelt-dot-org force-pushed the allow-bumping-patchlevel-constraints branch from 912a66d to e241ea4 Compare August 31, 2023 07:08
@verfriemelt-dot-org verfriemelt-dot-org changed the base branch from 2.5 to main August 31, 2023 07:08
@verfriemelt-dot-org
Copy link
Contributor Author

verfriemelt-dot-org commented Aug 31, 2023

rebased onto main 👍

@Seldaek Seldaek merged commit 1a2bd38 into composer:main Aug 31, 2023
20 checks passed
@Seldaek
Copy link
Member

Seldaek commented Aug 31, 2023

Thanks

@verfriemelt-dot-org verfriemelt-dot-org deleted the allow-bumping-patchlevel-constraints branch September 14, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants