Fix exit code 5 on composer require/create-project command #11616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 1, 2023
src/Composer/Installer.php
Outdated
| @@ -402,7 +404,7 @@ public function run(): int | |||
| $repoSet->addRepository($repo); | |||
| } | |||
|
|
|||
| return $auditor->audit($this->io, $repoSet, $packages, $this->auditFormat, true, $this->config->get('audit')['ignore'] ?? []) > 0 ? self::ERROR_AUDIT_FAILED : 0; | |||
| return $auditor->audit($this->io, $repoSet, $packages, $this->auditFormat, true, $this->config->get('audit')['ignore'] ?? []) > 0 && true === $this->errorOnAudit ? self::ERROR_AUDIT_FAILED : 0; | |||
There was a problem hiding this comment.
true === is useless as $this->errorOnAudit is already a boolean
|
Thanks, probably makes sense to do this only on request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11362, CI builds may fail with status code 5 if the composer command require/create-project is used.
This PR fix this BC break and the command will fail if the user has explicitly specified the
--auditflag