Make use of new PHP 8.4.0 function to replace implicit $http_response_header var #11995
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
force-pushed
the
php84fwd
branch
2 times, most recently
from
2b03322
to
03c6f61
Compare
|
@ondrejmirtes I see even with the release out now it still doesn't find these functions.. I guess the PHP_VERSION_ID check isn't enough to know that within the if the functions are available? If the target php version is 7.2 it assumes that everywhere right? If so I guess I'll baseline them for now. |
|
I'm not sure about the reason, I usually work on new PHP version after festure freeze. Feel free to open a bug report about this 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a new PHPStan release with phpstan/phpstan-src#3093