Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update should-i-commit-the-dependencies-in-my-vendor-directory.md #1718

Merged
merged 2 commits into from Mar 21, 2013
Merged

Update should-i-commit-the-dependencies-in-my-vendor-directory.md #1718

merged 2 commits into from Mar 21, 2013

Conversation

reinink
Copy link
Contributor

@reinink reinink commented Mar 20, 2013

Added a third option for including vendor dependencies in main GIT repo.

Update: Just noticed a grammatical error on line 28. Wow, my very first pull request and I missed it up. 馃憥

Add a third option for including vendor dependencies in main GIT repo.
@Seldaek
Copy link
Member

Seldaek commented Mar 21, 2013

You go to your patch-1 branch in your fork and edit the file again to fix the grammatical error. Aside from that, are you sure vendor/.git is working? I would think vendor/**/.git maybe or just .git would work.

@reinink
Copy link
Contributor Author

reinink commented Mar 21, 2013

@Seldaek Will do on the grammatical fix.

I've tested vendor/.git and it certainly works. I preferred that over .git, as it's clearer what the intention is, not to mention the confusion with the repo's main .git folder.

One note on this FAQs. I've tried the rm -rf vendor/**/.git command on OSX, and it does not work. However, rm -rf vendor/*/*/.git did work. I'm not overly familiar with the ** trick though, so I didn't want to make any changes here. Just thought I should mention it.

Tweak option #3 for including聽dependencies聽in a GIT repo.
@Seldaek
Copy link
Member

Seldaek commented Mar 21, 2013

Yeah I think the double ** expansion doesn't work everywhere. But anyway it's really not the best idea.

Seldaek added a commit that referenced this pull request Mar 21, 2013
Update should-i-commit-the-dependencies-in-my-vendor-directory.md
@Seldaek Seldaek merged commit 6b0a7d9 into composer:master Mar 21, 2013
digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013
Update should-i-commit-the-dependencies-in-my-vendor-directory.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants