Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic tests fix #361

Merged
merged 2 commits into from Feb 24, 2012
Merged

Cosmetic tests fix #361

merged 2 commits into from Feb 24, 2012

Conversation

wookieb
Copy link
Contributor

@wookieb wookieb commented Feb 24, 2012

tearDown remove directories created during setUp

}
mkdir($this->vendorDir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, it should also make sure that the directory is cleared before running the first test in case some old files remain from a previous failed run or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Seldaek added a commit that referenced this pull request Feb 24, 2012
@Seldaek Seldaek merged commit 3135ea2 into composer:master Feb 24, 2012
@Seldaek
Copy link
Member

Seldaek commented Feb 24, 2012

Thanks

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants