Improve status for unpushed branches #3633
Conversation
| @@ -120,6 +143,13 @@ protected function cleanChanges(PackageInterface $package, $path, $update) | |||
| { | |||
| GitUtil::cleanEnv(); | |||
| $path = $this->normalizePath($path); | |||
|
|
|||
| if ($this instanceof DvcsDownloaderInterface) { | |||
There was a problem hiding this comment.
this makes no sense. It will always be true
greg0ire
force-pushed
the
improve-status-for-unpushed-branches
branch
from
45c8061
to
542825d
Compare
|
What's the upside of this over #2253 (comment) ? |
|
From the description of #2253 this does not only work for branches that have diverged, but for changes branches that are behind their remote counterpart (but maybe the description is bad). Plus, it gives a better feedback with what exactly is wrong with status codes : there are different status codes for different situations (changes commited but not pushed, changes not commited, (changes commited and not pushed in one vendor && changes not commited in another)). |
|
Also, it is more generic : there is an interface that is introduced so that the same functionality can be implemented for mercurial, bazaar and your favorite DCVS. |
`composer status` now prevents overwriting Git package if changes have not been pushed.
greg0ire
force-pushed
the
improve-status-for-unpushed-branches
branch
from
542825d
to
9e30c9b
Compare
|
I just rebased, the tests are green. |
|
Better late than never I guess :) Thanks for merging that! |
This is a cleaned up, rebased, resurrection of #2085