Add a helper to disable process timeouts #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper can be included in custom script definitions by calling
"Composer\\Config::disableProcessTimeout".
Example:
{
"scripts": {
"watch": [
"Composer\\Config::disableProcessTimeout",
"vendor/bin/long-running-script --watch"
]
}
}
|
But as discussed in #8041, you could just |
|
Ah well, this is a pretty clever hack, which really doesn't add much code, so 👍 from me. |
|
Thanks! :) |
|
@beryllium Would you mind adding this to docs as well ? 😅 |
|
@sakshamsaxena For sure, just created #8093 for this. |
|
Do we have an ETA for when this will be launched, @Seldaek? This has been a feature that we've been looking forward to for many months. Thanks |
|
@Antnee hoping to release friday, sorry it's been so long between minor releases but #life |
|
That's awesome, thanks @Seldaek |
|
1.9 is out |
|
Yes! Thanks @Seldaek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about because Sculpin's blog skeleton was recently changed to use Composer to manage long running processes like
yarn encore --watchandsculpin generate --watch. Shortly thereafter, it was observed that this triggered the 5 minute default Composer timeout.It seemed unwise to set the entire Composer configuration to unlimited timeouts, and I felt that this narrower approach was potentially worthy of being included in Composer itself.
The helper can be included in custom script definitions by calling
"Composer\\Config::disableProcessTimeout".Example:
{ "scripts": { "watch": [ "Composer\\Config::disableProcessTimeout", "vendor/bin/sculpin generate --watch --server" ] } }