Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides a post download event #8655

Merged
merged 4 commits into from Apr 14, 2020
Merged

Provides a post download event #8655

merged 4 commits into from Apr 14, 2020

Conversation

heddn
Copy link
Contributor

@heddn heddn commented Feb 25, 2020

Start the conversation on resolving #8654

@heddn
Copy link
Contributor Author

heddn commented Feb 25, 2020

I think (hope) the use case for Drupal wanting to hash the zip downloads using its security mechanism makes sense. Linking in #5935, which proposed this some time ago, but didn't provide a strong use case.

@Seldaek Seldaek added this to the 2.0-core milestone Feb 28, 2020
@Seldaek
Copy link
Member

Seldaek commented Feb 28, 2020

Sounds reasonable to me, the question is whether this should be more specific than just file, and include the package info etc.. PRE_FILE_DOWNLOAD is triggered in other places like ComposerRepository, but I think the POST_* case really only makes sense for the package downloaders.

@heddn
Copy link
Contributor Author

heddn commented Feb 28, 2020

I looked all the places that did a PRE_FILE_DOWNLOAD and (to me) it only made sense in package downloading. We could always add it in more places later if we decide it is needed.

@heddn
Copy link
Contributor Author

heddn commented Apr 9, 2020

Rebased PR so it now has no conflicts. Any chance on this still landing in 2.0?

@Seldaek
Copy link
Member

Seldaek commented Apr 14, 2020

Needs a few more changes but yes no worries this will absolutely make it in 2.0.

@heddn
Copy link
Contributor Author

heddn commented Apr 14, 2020

Working on addressing the latest feedback.

heddn and others added 3 commits April 14, 2020 15:24
@heddn
Copy link
Contributor Author

heddn commented Apr 14, 2020

Feedback addressed.

@Seldaek Seldaek merged commit 1883832 into composer:master Apr 14, 2020
@Seldaek
Copy link
Member

Seldaek commented Apr 14, 2020

Thanks for the quick update.

Seldaek added a commit that referenced this pull request Apr 14, 2020
@Seldaek
Add post-file-download event to docs, refs #8655
feefa9b
@heddn heddn deleted the post_download branch April 14, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seldaek Seldaek Seldaek left review comments

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.0-core
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heddn @Seldaek