Plugin helpers for v2 #9278
Merged
Plugin helpers for v2 #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re easily when one does not care about async
naderman
approved these changes
Oct 13, 2020
| if ($this->httpDownloader) { | ||
| $this->httpDownloader->enableAsync(); | ||
| } | ||
| $this->httpDownloader->enableAsync(); |
There was a problem hiding this comment.
I know this is not an issue with this PR, but it seems odd that we mutate the client here.
There was a problem hiding this comment.
Yeah it's not ideal, but it lets people create and use a sync client without shooting themselves in the foot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9209
Open for more ideas if someone has anything to add here.