Add --format option to composer fund command
#9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
suggested changes
Feb 9, 2021
* Return empty json when no funding found instead of text * Include all funding urls (do not override)
|
@stof thanks for reviewing this. |
Seldaek
approved these changes
Feb 10, 2021
stof
suggested changes
Feb 11, 2021
src/Composer/Command/FundCommand.php
Outdated
| foreach ($fundings as $vendor => $links) { | ||
| $fundingJson[$vendor] = array(); | ||
| foreach ($links as $url => $packages) { | ||
| $fundingJson[$vendor]['packages'] = $packages; |
There was a problem hiding this comment.
this is still wrong. The list of packages is not per vendor but per url. Otherwise, you loose all except the ones of the last link.
There was a problem hiding this comment.
@stof makes sense. Instead of building my own array the existing one is now used. So the issue should be fixed.
May i ask for another review? :-)
stof
approved these changes
Feb 24, 2021
|
Thanks! |
johnstevenson
pushed a commit
to johnstevenson/composer
that referenced
this pull request
Mar 1, 2021
* Add --format option to `composer fund` command Co-authored-by: Jochen Roth <jochen.roth@b13.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
currently building a little GUI around composer. I want to show funding information in the GUI.
Therefore i added
--formatoption to thecomposer fundcommand which allows to outputfund details as JSON.