Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions with build metadata don't show on Packagist #363

Closed
asgrim opened this issue Nov 4, 2013 · 4 comments
Closed

Versions with build metadata don't show on Packagist #363

asgrim opened this issue Nov 4, 2013 · 4 comments

Comments

@asgrim
Copy link

asgrim commented Nov 4, 2013

I have tagged two versions of my project to test out using build metadata, 0.1.7-beta+5021 and 0.1.7-beta. As would be expected 0.1.7-beta appears fine (see here), but 0.1.7-beta+5021 does not.

I don't know how strictly Composer/Packagist sticks to Semantic Versioning, but this is what I found about it:

Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Build metadata SHOULD be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85.

Is scope to include build metadata in version numbers parsed by Composer & Packagist?

@Seldaek
Copy link
Member

Seldaek commented Nov 4, 2013

I guess we could add support for this by just ignoring whatever follows the + right? The thing is, if you have both 0.1.7-beta and 0.1.7-beta+5021, you're just creating noise. Or do you intend to have only the latter if that becomes supported?

@asgrim
Copy link
Author

asgrim commented Nov 4, 2013

That is correct - I tagged +5021 first and noticed it didn't appear on Packagist, then made sure it was working without the metadata, hence two tags. Ignoring the metadata seems like a good idea - it is just metadata. You could parse it and display it somewhere on Packagist, but evidently using metadata isn't that popular, so I expect the majority wouldn't find it all that useful.

@andrerom
Copy link

@Seldaek Struck by this as well, and imho we should either expand the composer doc on what version numbers are supported and remove link to semantic versioning, or implement the whole thing ;)

@Seldaek
Copy link
Member

Seldaek commented Nov 14, 2013

Closing in favor of composer/composer#2422 since it's not really a packagist issue.

@Seldaek Seldaek closed this as completed Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants