Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Move functions out of Intervals class #112

Closed
simonberger opened this issue Sep 13, 2020 · 1 comment
Closed

Proposal: Move functions out of Intervals class #112

simonberger opened this issue Sep 13, 2020 · 1 comment

Comments

@simonberger
Copy link

simonberger commented Sep 13, 2020

Intervals class got really big and consists of functions of very different tasks. Out of blackbox view they also have not much to do with the idea of the Intervals class. Similarity is just using intervals internally.

I like to do the following changes:

  • Move compactConstraint to new Optimize class
  • Move isSubsetOf and haveIntersections to Comparator
  • Set generateIntervals to public as it is used in haveInspections or solve that differently.

If you agree to this it should be done in a new major release. Otherwise we end up in duplicated code or cross references to deprecate the old functions.

@Seldaek
Copy link
Member

Seldaek commented Sep 14, 2020

IMO it's kinda ok as it is, the public API of the class isn't huge and all somewhat related to manipulating constraints. Maybe the classname isn't ideal, but given the few people interested in using this directly i don't really feel like these minor improvements warrant yet another major release. We can keep it open for consideration if anything else comes along requiring a major release tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants