Invalid version string for some default PHP version naming scheme

[lcharette]

We're currently using the equivalent of this line of code :

$satisfies = Semver::satisfies(phpversion(), '^7.2');

Issue is, our CI returns this php version (which is technically invalid I know) : 7.2.34-18+ubuntu20.04.1+deb.sury.org+1. So when running Unit/Feature Tests CI fails with this error :

Invalid version string "7.2.34-18+ubuntu20.04.1+deb.sury.org+1"  

VersionParser::normalize basically ends as 7.2.34-18 instead of 7.2.34.

I know technically it's the PHP version that is at fault here, but this is a common naming scheme from packaged provided PHP on some distro. Even if we were to change our test to go around, the issue would still arise for some users when using this code on their server with this kind of version scheme (and somehow Composer itself doesn't complain about it...?)

[stof]

the reason why composer does not complain is because it has a special handling for such weird php versions: https://github.com/composer/composer/blob/b6826f352390b4c952be8fd75d60cfd4f6f39f11/src/Composer/Repository/PlatformRepository.php#L97-L103

This is not something implemented in the composer/semver package, because that would allow such weird versioning scheme for all packages out there (thus, that's not semver anymore)

[stof]

bote that for your use case about checking only for being higher than a given PHP version, you could do a check on PHP_VERSION_ID instead of matching a semver constraint against phpversion() and having to deal with cleaning it.

[lcharette]

Thanks for the quick reply and pointing me in the right direction. I'll probably got the PHP_VERSION_ID or Composer like route.