Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty ini handling #105

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

pdelre
Copy link
Contributor

@pdelre pdelre commented Feb 13, 2020

When XdebugHandler comes across an empty ini file, it report a Unable to read ini error. This appears to be caused by loose type matching when calling file_get_contents.

The result of this error, in particular, causes composer to not restart itself with xdebug disabled.

@johnstevenson johnstevenson merged commit 66a6269 into composer:master Feb 19, 2020
@johnstevenson
Copy link
Member

Many thanks for this.

The original idea was that you were unlikely to have a totally empty ini because they usually contain something, even if it is commented out. And having one would indicate something wrong with your setup.

However perhaps that approach was too strict.

@pdelre pdelre deleted the fix-empty-ini-handling branch February 20, 2020 10:22
@pdelre
Copy link
Contributor Author

pdelre commented Feb 20, 2020

Thank you for the merge. Indeed, I did discover this due to a bad configuration setup.

Is there a release process I could assist with? I just realized my PR didn't update the Unreleased section of the CHANGELOG. I'd be happy to assist with any additional code changes that makes it easier to cut the 1.4.1 release.

@johnstevenson
Copy link
Member

No worries about updating the CHANGELOG as I'll do that prior to cutting a new release. I tend to wait a week or two in case something else pops up.

@GrahamCampbell
Copy link
Contributor

It would be great to have this release done in time to have it included in composer 1.10.0 stable. :)

@GrahamCampbell
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants