Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line breaks not escaped in parsing when parameters for container are present #546

Closed
2 of 4 tasks
mchangrh opened this issue Oct 13, 2022 · 1 comment
Closed
2 of 4 tasks

Comments

@mchangrh
Copy link

Do you want to request a feature or report a bug?

  • feature request
  • bug report

Please provide a sample input docker run command

docker run -d \ -v vol:/tmp \ hello-world \ --parameter

What is the current output?*

version: '3.3'
services:
    \:
        volumes:
            - 'vol:/tmp'
        image: \

What is the expected/desired output?

version: '3.3'
services:
    hello-world:
        volumes:
            - 'vol:/tmp'
        image: hello-world

Are you willing/able to attempt a fix?

Most issues can be trivially addressed by updating this mapping:

https://github.com/magicmark/composerize/blob/dcae8ace865e2eef69e5bd27c4a9a320f56cac75/packages/composerize/src/mappings.js#L62-L66

  • Is this the case for your issue?
  • Would you be able to try? :)

Thanks for following this template and making composerize better for everyone else too!

sharevb added a commit to sharevb/composerize that referenced this issue Sep 18, 2023
… options

Arrange parsing of boolean and ignored args ; multiline with \, fake multiline with \ and no LF
Related to composerize#546 composerize#138 composerize#38 composerize#31
@sharevb
Copy link
Collaborator

sharevb commented Oct 14, 2023

Hi, this is solved by my PR #571 deployed at https://deploy-preview-571--composerize.netlify.app/

@sharevb sharevb closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants