Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put unreliable/timing/resource sensitive tests under dev flag #918

Closed
harendra-kumar opened this issue Feb 8, 2021 · 3 comments
Closed

Put unreliable/timing/resource sensitive tests under dev flag #918

harendra-kumar opened this issue Feb 8, 2021 · 3 comments
Assignees
@adithyaov
Milestone
0.8.2

Comments

@harendra-kumar
Copy link
Member

Some tests fail due to timing issues. We should put all such tests under dev flag. Also, some tests may depend on an particular socket being available on the test machine, we should also put such tests under dev flag. If the tests are not reliable then distributions like nix which depend on the test results are likely to mark the package broken.
@harendra-kumar harendra-kumar added this to the 0.8.0 milestone Feb 8, 2021
@harendra-kumar
Copy link
Member Author

Also, we can remove the GHC heap restrictions for the released version. Maybe put them under a flag so that we can keep using those for CIs to catch issues, but do not enable during normal compilation.

@harendra-kumar
Copy link
Member Author

Another example of a failing test: https://ci.appveyor.com/project/harendra-kumar/streamly/builds/38059019? Why is this failing?

@harendra-kumar harendra-kumar modified the milestones: 0.8.0, 0.8.1 Jul 18, 2021
@harendra-kumar
Copy link
Member Author

We have a flag include-flaky-tests for such tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adithyaov adithyaov

Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

No branches or pull requests
2 participants
@harendra-kumar @adithyaov