Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1031 joinOuterMerge #1419

Draft
wants to merge 2 commits into
base: issue_1031_joinLeftMerge
Choose a base branch
from
Draft

Issue 1031 joinOuterMerge #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cd80ba
Implement joinOuterMerge API
rnjtranjan Jan 6, 2022
45fc9d9
Fix review cooments
rnjtranjan Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Streamly/Internal/Data/Stream/IsStream/Top.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module Streamly.Internal.Data.Stream.IsStream.Top
, joinLeftMerge
, hashLeftJoin
, outerJoin
, mergeOuterJoin
, joinOuterMerge
, hashOuterJoin
)
where
Expand Down Expand Up @@ -473,11 +473,14 @@ hashOuterJoin _eq _s1 _s2 = undefined
--
-- Time: O(m + n)
--
-- /Unimplemented/
{-# INLINE mergeOuterJoin #-}
mergeOuterJoin :: -- Monad m =>
-- /Pre-release/
{-# INLINE joinOuterMerge #-}
joinOuterMerge :: (IsStream t, MonadIO m, Eq a, Eq b) =>
(a -> b -> Ordering) -> t m a -> t m b -> t m (Maybe a, Maybe b)
mergeOuterJoin _eq _s1 _s2 = undefined
joinOuterMerge eq s1 =
IsStream.fromStreamD
. StreamD.joinOuterMerge eq (IsStream.toStreamD s1)
. IsStream.toStreamD
Comment on lines +480 to +483
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a point free notation, having s2 here seems more eloquent.


------------------------------------------------------------------------------
-- Set operations (special joins)
Expand Down