Wrong seconds per block in the DAI interest rate model

[MathisGD]

compound-protocol/contracts/DAIInterestRateModelV3.sol

Line 17 in a3214f6

uint256 private constant SECONDS_PER_BLOCK = 15;

The average number of second between each block used here is 15, while since the Merge, the it is now stable at 12 seconds. This means that the supply rate given by getSupplyRate would be wrong.

Some discussions are open to re-enable deposits to the DSR from cDAI, and it will not be possible to re-use the old DAIInterestRateModelV3 available at 0xfed941d39905b23d6faf02c8301d40bd4834e27f because of this reason.

[fmorisan]

Would an easy fix for this just be a simple change like so?

uint256 private constant SECONDS_PER_BLOCK = 12;

[MathisGD]

By the way, I just noticed that all the other IRMs assume that the number of second between each block is 15 (2 102 400 blocks per year). But that's not that of an issue, because it is only used to covert the parameters from yearly to per-block at the construction of the contract.