Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce gas costs in CToken#redeemFresh #140

Closed
wants to merge 1 commit into from
Closed

Reduce gas costs in CToken#redeemFresh #140

wants to merge 1 commit into from

Conversation

TylerEther
Copy link
Contributor

  • Reduces gas by 3666
  • Inlines a sanity check which is not specific to the comptroller

@TylerEther
Reduce gas costs in CToken#redeemFresh
9cd1a94 
- Reduces gas by 3666
- Inlines a sanity check which is not specific to the comptroller
jflatow
jflatow reviewed Aug 11, 2021
View reviewed changes
contracts/Comptroller.sol

// Require tokens is zero or amount is also zero
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The immutable tokens still need this, don't think we can get rid of redeemVerify until all cTokens are upgraded to not need it

@jflatow
Copy link
Contributor

jflatow commented Nov 16, 2021

Closing since there are outstanding issues and conflicts with more active cToken changes being audited now #152

@jflatow jflatow closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflatow jflatow jflatow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TylerEther @jflatow