Add test for eval order and side effects examples + bugfix #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
help wanted
flip1995
force-pushed
the
phil/side_effects_fix
branch
from
8e1e534
to
530cc58
Compare
|
I gone through the JLS "Evaluation Order" chapter and copied/generated tests from there. Didn't get to verify them yet. Will do tomorrow. |
flip1995
force-pushed
the
phil/side_effects_fix
branch
2 times, most recently
from
0a36ad3
to
7b9df5a
Compare
problame
reviewed
Dec 6, 2018
|
ETA Wednesday eve Doesn't seem urgent to me. The optimizations shouldn't depend on this. |
flip1995
force-pushed
the
phil/side_effects_fix
branch
from
1ff0597
to
aac9581
Compare
|
Well that was a quick and easy fix 😄 r? @joshuabach |
flip1995
added
S-waiting-on-review
flip1995
changed the title
joshuabach
approved these changes
Dec 14, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 14, 2018
166: Add test for eval order and side effects examples + bugfix r=joshuabach a=flip1995 With the examples of the test our compiler is consistent with javac. I will continue to search for more exec order and side effect tests. Currently only the tests from the slides are implemented. If anyone has an idea for a test case feel free to add it. Co-authored-by: flip1995 <hello@philkrones.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the examples of the test our compiler is consistent with javac. I will continue to search for more exec order and side effect tests.
Currently only the tests from the slides are implemented.
If anyone has an idea for a test case feel free to add it.