-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course survey upload failure (fa18 data) #181
Comments
In the future, for distinguishing instructors with identical first/last names, lacking further disambiguation (student IDs, internal survey IDs, semester heuristics), we should default to the most-recently-created instructor, or maybe instructor with the most recent course survey data (favoring instructors who last taught spring 2019 over instructors who last taught spring 2015). |
It appears the error is being caused by save validations occurring after validates_uniqueness_of :first_name, scope: :last_name Kevin Lin does not have a unique first name in the space of all TAs with a common last name (i.e. there is another Kevin Lin, so this validation fails, causing the course upload to fail. The fix for this is unclear. It's also unclear how Kevin Lin created his account in the first place (manual intervention may have occurred), but it seems like the solution involves either:
The third seems like the most logically correct solution. The second seems like the most practically simple solution (but the most duct-tapey). |
Appears to be fixed? |
Announcements for home page
mowen's been getting two errors while uploading course survey data for fa18.
There are two separate issues here:
There are two Kevin Lins in the database. This is somehow causing an error to be thrown at csec_admin_helper.rb#L133, because Instructors are only disambiguated by first,last name, and not id.
There is an extra data point in this semester's survey, 'Response Rate'. This extra SurveyQuestion is not an entry in the database, so the lookup fails and an error is thrown at csec_admin_helper.rb#L108
The text was updated successfully, but these errors were encountered: