Remove secrets #188
Merged
Remove secrets #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvperrin
approved these changes
Apr 23, 2019
|
Ah, I see you mentioned that in #175 already, and opted not to rewrite history, which sounds great to me if the secret can be rotated effectively. I also can't find any other credentials, but I haven't done a very comprehensive search either, just looked through the initializers and grep'd for a few keywords. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #175.
Removes the recaptcha site_key, secret_key from plaintext, loads from the secrets.yml.
I'm not sure if there are any other secrets, a quick grep for "key" doesn't pull up anything.
Of note, this causes user registration to fail for developers without access to the recaptcha secret keys; I'm not sure if there's a good way around this, or if we can disable recaptcha validation in dev environments.
I've judged this to be an issue not worth fixing, because developers will be making admin users from the command line anyways, and probably rarely from the web interface. (Changes to the recaptcha will only be focused on the new site, anyways.)