Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to cats-effect-3 #189

Merged
merged 13 commits into from
Aug 17, 2021
Merged

Update to cats-effect-3 #189

merged 13 commits into from
Aug 17, 2021

Conversation

dininski
Copy link
Contributor

Closes #185

LukaJCB
LukaJCB approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@dininski
Copy link
Contributor Author

dininski commented Aug 2, 2021

This PR should be ready to merge. However because https://github.com/compstak/kafka-connect-http4s has not yet released a ce3-compatible version yet, the PR uses a GH project to pull in a CE3 compatible version of kafka-connect-http4s.

@LukaJCB
Copy link
Contributor

LukaJCB commented Aug 3, 2021

Http4s just released a CE3 compatible 0.23.0 final, so let's get kafka-connect-http4s onto that and then get this merged! Tysm!

@dininski
Copy link
Contributor Author

dininski commented Aug 9, 2021 •
edited

Http4s just released a CE3 compatible 0.23.0 final, so let's get kafka-connect-http4s onto that and then get this merged! Tysm!

Updated the related PR with 0.23.1, which is latest stable. Mind taking a look? Keep it mind that it also needs to be released in order to update this PR 🙂

@dininski
Copy link
Contributor Author

@LukaJCB Updated the PR with the latest released version of kafka connect http4s (0.6.0), so it should be fine to merge and release now.

@LukaJCB
Copy link
Contributor

LukaJCB commented Aug 17, 2021

Awesome thanks!

@LukaJCB LukaJCB merged commit 642936f into compstak:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cats Effect 3 support
2 participants
@dininski @LukaJCB