PCHR-2124: Remove styleguide backstop scenario + misc #1707

AkA84 · 2017-04-11T10:57:45Z

This PR contains the following:

Removed the styleguide backstopjs scenario, as now the styleguide extension itself will have that scenario (see here)
Renamed backstop:action tasks in backstopjs:action
Added backstopjs:approve task
Now on page ready backstop will close the notification (if any) before taking a screenshot
Using the cid = 2 in all scenarios
Removed some of the scenarios for the Documents page (T&A), because of this issue. PhantomJS has a bug with how it parses dates, and that leads the Documents page to not show any documents, which then leads to errors when CasperJS tries to click on documents that are not there. I don't know of any solutions yet, so i could only removed those scenarios

This is due to ariya/phantomjs#11151 which makes those tests unusable

bmnepali · 2017-04-11T11:08:02Z

uk.co.compucorp.civicrm.hrcore/backstop_data/page-objects/page.js

+/**
+ * [closeNotifications description]
+ * @return {[type]} [description]
+ */


If the comment block is necessary, it does not have a correct description.

Alessandro Verdura added 5 commits April 11, 2017 12:48

PCHR-2124: Adjustments to gulp files + add approve task

47e94f3

PCHR-2124: Close notification on page ready

c27d2a5

PCHR-2124: Use cid=2 in scenario

6e641a3

PCHR-2124: Remove failing documents tests

7d87b20

This is due to ariya/phantomjs#11151 which makes those tests unusable

PCHR-2124: Remove styleguide scenario

bde8b65

bmnepali suggested changes Apr 11, 2017

View reviewed changes

PCHR-2124: Add methods documentation

246f0ea

bmnepali approved these changes Apr 11, 2017

View reviewed changes

AkA84 merged commit a2e67cf into staging Apr 11, 2017

AkA84 deleted the PCHR-2124-add-backstopjs branch April 11, 2017 14:14

Provide feedback